Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new MacroSAN storage backend implementation and corresponding unit tests to integrate the cinder-volume-macrosan charm into Sunbeam’s storage backend framework.
Changes:
- Introduce
MacrosanBackend+MacrosanConfigwith secret-marked password fields and protocol selection. - Add MacroSAN-specific unit tests (backend interface + config validation).
- Register MacroSAN in shared backend test fixtures and uniqueness/expectations checks.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sunbeam-python/sunbeam/storage/backends/macrosan/backend.py | Implements MacroSAN backend + config model for deployment/terraform var generation. |
| sunbeam-python/sunbeam/storage/backends/macrosan/init.py | Declares the MacroSAN backend package. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py | Adds macrosan_backend fixture and includes MacroSAN in parametrized backend testing. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py | Extends backend uniqueness and expectation tests to include MacroSAN. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_macrosan.py | Adds MacroSAN backend tests and protocol validation tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmad-can
force-pushed
the
feature/generate-macrosan-charm
branch
from
9b10de7 to
a1f3733
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/983857